Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(ci): add a sample kmod source to test that we are able to build a kmod after kernel headers are installed #2

Closed
wants to merge 1 commit into from
Closed

new(ci): add a sample kmod source to test that we are able to build a kmod after kernel headers are installed #2

wants to merge 1 commit into from

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 8, 2024

No description provided.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 8, 2024

Draft while i test it.

@FedeDP FedeDP force-pushed the fix/always_create_symlinks branch 4 times, most recently from c251406 to e3e9a50 Compare May 8, 2024 13:33
@FedeDP
Copy link
Contributor Author

FedeDP commented May 8, 2024

Testing the action changes here: falcosecurity/libs#1855

@FedeDP FedeDP mentioned this pull request May 8, 2024
Merged
@FedeDP
Copy link
Contributor Author

FedeDP commented May 8, 2024

Once #3 is accepted, i will rebase this one to only include CI improvements so that we can further discuss them.

@FedeDP FedeDP mentioned this pull request May 8, 2024
Merged
@FedeDP FedeDP force-pushed the fix/always_create_symlinks branch 2 times, most recently from d73ffce to d234377 Compare May 9, 2024 11:04
@FedeDP FedeDP force-pushed the fix/always_create_symlinks branch from d234377 to ebdda45 Compare May 9, 2024 11:04
@FedeDP
Copy link
Contributor Author

FedeDP commented May 9, 2024

Rebased. As stated earlier, we need to run the CI test workflow on an actuated node because we need a vanilla kernel.
Right now the worfklow fails because of:

warning: Could not find remote branch v6.5.0-1018-azure to clone.
fatal: Remote branch v6.5.0-1018-azure not found in upstream origin

@FedeDP FedeDP changed the title fix(action): always create symlinks, even when running from cached. new(ci): add a sample kmod source to test that we are able to build a kmod after kernel headers are installed May 9, 2024
@alexellis
Copy link
Member

@FedeDP could you move these tests to -> https://github.com/actuated-samples/kmod-sample

I made a repo on an org arm64 actuated servers are enabled.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 14, 2024

Mmmh if i move the test to another repo, how can i trigger it everytime a change to action.yml happens here?

@alexellis
Copy link
Member

alexellis commented May 14, 2024 •
edited
Loading

There is no real need for that. This is a trivial action like a "macro".

I created the separate repo for you, could you move the sample over there please?

@FedeDP
Copy link
Contributor Author

FedeDP commented May 14, 2024

I created the separate repo for you, could you move the sample over there please?

Yes, do you want the CI job too (eg: on push to master)?

@alexellis alexellis closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FedeDP @alexellis