Client to server streaming fixes #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method essentially does the same as `stream` previously did, but instead of returning the stream it does return the SteamControler. This makes it possible for the abort the streaming on the client side by calling `close()` on the controller. The `stream()` uses `streamControllable()` to return the stream, the method is still keept to not break existing usage of the method.
prevents an index out of range exceptions and uses the correct invocation ids for sent items
This sets either the 'error' or the 'result' field, or neither as it is specified here: https://github.com/dotnet/aspnetcore/blob/main/src/SignalR/docs/specs/HubProtocol.md This prevents exceptions on the server when the client closes the stream.
not all changes where committed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes creation of client to server streams as well as an unexpected connection close if the client closes the stream (wrong competion message).
Please note this pull request also includes the changes from #98