Use httpbin instead of Postgres to prove secrets injection #2

florisvdg · 2019-09-02T06:58:07Z

No description provided.

mackenbach

I have one small comment to make it even more self-explanatory. Feel free to merge when satisfied.

mackenbach · 2019-09-04T14:38:18Z

secrethub.env

@@ -0,0 +1 @@
+HTTPBIN_BEARER = {{ $app/httpbin/bearer }}


Can we call this HTTPBIN_TOKEN or something? This doesn't signal to me it's a secret. Only if you're familiar with the concept of a bearer token does this make some sense.

Use httpbin instead of Postgres to prove secrets injection

91a036c

florisvdg requested a review from mackenbach September 2, 2019 06:58

mackenbach approved these changes Sep 4, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use httpbin instead of Postgres to prove secrets injection #2

Use httpbin instead of Postgres to prove secrets injection #2

florisvdg commented Sep 2, 2019

mackenbach left a comment

mackenbach Sep 4, 2019

Use httpbin instead of Postgres to prove secrets injection #2

Are you sure you want to change the base?

Use httpbin instead of Postgres to prove secrets injection #2

Conversation

florisvdg commented Sep 2, 2019

mackenbach left a comment

Choose a reason for hiding this comment

mackenbach Sep 4, 2019

Choose a reason for hiding this comment