Merge pull request #8 from sebadob/improve-api

improve internal API slightly for better DX

src/bucket.rs

@@ -56,6 +56,7 @@ pub struct Bucket {
 }
 
 #[allow(dead_code)]
+#[allow(clippy::assigning_clones)] // false-positive warnings
 impl Bucket {
     fn host_domain(&self) -> String {
         match self.host.domain() {

src/credentials.rs

@@ -5,7 +5,7 @@ use std::env;
 use std::fmt::{Debug, Formatter};
 
 #[derive(Debug, Clone)]
-pub struct AccessKeyId(String);
+pub struct AccessKeyId(pub String);
 
 impl AsRef<str> for AccessKeyId {
     fn as_ref(&self) -> &str {
@@ -20,7 +20,7 @@ impl AccessKeyId {
 }
 
 #[derive(Clone)]
-pub struct AccessKeySecret(String);
+pub struct AccessKeySecret(pub String);
 
 impl Debug for AccessKeySecret {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
@@ -47,6 +47,16 @@ pub struct Credentials {
 }
 
 impl Credentials {
+    pub fn new<S>(key: S, secret: S) -> Self
+    where
+        S: Into<String>,
+    {
+        Self {
+            access_key_id: AccessKeyId(key.into()),
+            access_key_secret: AccessKeySecret(secret.into()),
+        }
+    }
+
     pub fn try_from_env() -> Result<Self, S3Error> {
         let access_key_id = env::var("S3_ACCESS_KEY_ID")?;
         let access_key_secret = env::var("S3_ACCESS_KEY_SECRET")?;

src/lib.rs

@@ -30,9 +30,16 @@ mod types;
 
 /// S3 Region Wrapper
 #[derive(Debug, Clone)]
-pub struct Region(String);
+pub struct Region(pub String);
 
 impl Region {
+    pub fn new<S>(region: S) -> Self
+    where
+        S: Into<String>,
+    {
+       Self(region.into())
+    }
+
     pub fn try_from_env() -> Result<Self, S3Error> {
         Ok(Self(env::var("S3_REGION")?))
     }