-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failures when run with --all-features
#2464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! I think I fixed one of the failures already, which causes the conflict. |
gretchenfrage
force-pushed
the
issue-2463
branch
from
October 29, 2024 23:10
d8962b1
to
db1367c
Compare
Agreed! This PR should be updated now accordingly. |
seanmonstar
approved these changes
Oct 30, 2024
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Dec 27, 2024
Bumps reqwest from 0.12.9 to 0.12.10. Release notes Sourced from reqwest's releases. v0.12.10 What's Changed Add ClientBuilder::connector_layer() to allow customizing the connector stack. by @jlizen in seanmonstar/reqwest#2496 Add ClientBuilder::http2_max_header_list_size() option by @DSharifi in seanmonstar/reqwest#2465 Fix decompression of chunked bodies so the connections can be reused more often by @Andrey36652 in seanmonstar/reqwest#2484 Fix propagating body size hint (content-length) information when wrapping bodies by @seanmonstar in seanmonstar/reqwest#2503 New Contributors @DSharifi made their first contribution in seanmonstar/reqwest#2465 @gretchenfrage made their first contribution in seanmonstar/reqwest#2464 @hsivonen made their first contribution in seanmonstar/reqwest#2470 @ovnicraft made their first contribution in seanmonstar/reqwest#2469 @Nuhvi made their first contribution in seanmonstar/reqwest#2473 @caojen made their first contribution in seanmonstar/reqwest#2488 @Andrey36652 made their first contribution in seanmonstar/reqwest#2484 @jlizen made their first contribution in seanmonstar/reqwest#2499 Thanks @seanmonstar @nyurik Full Changelog: seanmonstar/[email protected] Changelog Sourced from reqwest's changelog. v0.12.10 Add ClientBuilder::connector_layer() to allow customizing the connector stack. Add ClientBuilder::http2_max_header_list_size() option. Fix propagating body size hint (content-length) information when wrapping bodies. Fix decompression of chunked bodies so the connections can be reused more often. Commits 409cff3 v0.12.10 ea48da7 docs: fix a few spelling issues (#2478) 3ce98b5 fix: propagate Body::size_hint when wrapping bodies (#2503) 44ca5ee remove Clone from connect::Unnameable for now (#2502) 2a7c1b6 feat: allow pluggable tower layers in connector service stack (#2496) 8a2174f chore: in README, update requirements to mention rustls along with vendored o... d36c0f5 perf: fix decoder streams to make pooled connections reusable (#2484) 4367d30 ci: pin hashbrown for msrv job (#2488) e2d4b14 docs: document using non-zero ports in resolved addresses (#2473) 6e21413 chore: fix a number of newer clippy lints (#2469) Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2463.
I'm also wondering if we could alter the CI to make it run tests with
--all-features
to avoid this occurring again in the future?