Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: fontawesome support #1266

Merged
merged 3 commits into from
Oct 21, 2024
Merged

rm: fontawesome support #1266

merged 3 commits into from
Oct 21, 2024

Conversation

dgarcia360
Copy link
Collaborator

Closes #1220

How to test

  1. Clone the PR and build the docs.
  2. Check icons render as expected:

annastuchlik
annastuchlik approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit 9a8ae54 into scylladb:master Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annastuchlik annastuchlik annastuchlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove font awesome
2 participants
@dgarcia360 @annastuchlik