set DOCKER_HOST only if needed #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we have places where we use a specific DOCKER_HOST in order to be able to support case of running the monitoring stack inside a running podman instance via socket, those places changing the DOCKER_HOST are breaking this usage, and were preventing the monitoring stack from starting
|
a PR should fix an issue, can you open one? |
|
It's in the context of this issue |
fruch
added a commit
to fruch/scylla-cluster-tests
that referenced
this pull request
Jan 10, 2024
* podman now defaults to short-name-mode="enforcing", and the monitor stack doesn't able to pull images when working via socket, it doesn't have tty to offer which repository to alias it, setting short-name-mode="permissive" on ~/.config/containers/registries.conf alleviate this issue * scylla-monitoring was using DOCKER_HOST inside it's start scripts, hence breaking our ability to use it to point to podman socket, a fix was subbmitted but until then we patch those out of the scripts so older collected monitoring data can be used Ref: scylladb/scylla-monitoring#2149 Fixes: scylladb#7080
Merged
2 tasks
fruch
added a commit
to fruch/scylla-cluster-tests
that referenced
this pull request
Jan 11, 2024
* podman now defaults to short-name-mode="enforcing", and the monitor stack doesn't able to pull images when working via socket, it doesn't have tty to offer which repository to alias it, setting short-name-mode="permissive" on ~/.config/containers/registries.conf alleviate this issue * scylla-monitoring was using DOCKER_HOST inside it's start scripts, hence breaking our ability to use it to point to podman socket, a fix was subbmitted but until then we patch those out of the scripts so older collected monitoring data can be used Ref: scylladb/scylla-monitoring#2149 Fixes: scylladb#7080
|
@fruch I've backported to branch 4.6, this means for QA it is already available |
thanks mean while, I'm patching it at SCT end, for people to be able to retrieve monitor data that didn't yet had this fix (we are caching the monitoring stack with the data) |
fruch
added a commit
to scylladb/scylla-cluster-tests
that referenced
this pull request
Jan 11, 2024
* podman now defaults to short-name-mode="enforcing", and the monitor stack doesn't able to pull images when working via socket, it doesn't have tty to offer which repository to alias it, setting short-name-mode="permissive" on ~/.config/containers/registries.conf alleviate this issue * scylla-monitoring was using DOCKER_HOST inside it's start scripts, hence breaking our ability to use it to point to podman socket, a fix was subbmitted but until then we patch those out of the scripts so older collected monitoring data can be used Ref: scylladb/scylla-monitoring#2149 Fixes: #7080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have places where we use a specific DOCKER_HOST in order to be able to support case of running the monitoring stack inside a running podman instance via socket, those places changing the DOCKER_HOST are breaking this usage, and were preventing the monitoring stack from starting