fix(scan_operations): add retry policy to cql query #9600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node where scan operations was started could be used by disruptive nemesis. If node was restarted/stopped while scan query had been running, the scan operation would be terminated and error event and message will mark test as failed. Add to cql session ExponetionalBackoffRetryPolicy which allow to retry the query, if node was down and once it back, query will be succesfully finished Fixes: scylladb#9284
aleksbykov
added
backport/6.2
backport/2024.2
soyacz
reviewed
Dec 23, 2024
| @@ -460,6 +474,9 @@ def execute_query(self, session, cmd: str, | |||
| | FullPartitionScanReversedOrderEvent]) -> None: | |||
| self.log.debug('Will run command %s', cmd) | |||
| validate_mapreduce_service_requests_start_time = time.time() | |||
| session.cluster.default_retry_policy = ExponentialBackoffRetryPolicy(**self._exp_backoff_retry_policy_params) | |||
| session.default_timeout = self._session_execution_timeout | |||
There was a problem hiding this comment.
is there a difference between self._request_default_timeout and self._request_default_timeout? maybe it could be reused?
fruch
reviewed
Dec 23, 2024
| @@ -120,6 +125,8 @@ def execute_query( | |||
| | FullPartitionScanReversedOrderEvent]) -> ResultSet: | |||
| # pylint: disable=unused-argument | |||
| self.log.debug('Will run command %s', cmd) | |||
| session.cluster.default_retry_policy = ExponentialBackoffRetryPolicy(**self._exp_backoff_retry_policy_params) | |||
There was a problem hiding this comment.
this is a bit weird it comes next to the code executing the query, and no the code creating the session.
I would recommend consolidating the session creating code into something like:
@property
def cql_connection(self, **kwargs):
with self.fullscan_params.db_cluster.cql_connection_patient(
node=self.db_node,
user=self.fullscan_params.user,
password=self.fullscan_params.user_password, **kwargs) as session:
session.cluster.default_retry_policy = ExponentialBackoffRetryPolicy(**self._exp_backoff_retry_policy_params)
session.default_timeout = self._request_default_timeout
yield sessionthere way too many repetitions of applying this retry, and it should be across the board for all of the sessions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node where scan operations was started could be
used by disruptive nemesis. If node was restarted/stopped
while scan query had been running, the scan operation would
be terminated and error event and message will mark
test as failed.
Add to cql session ExponentialBackoffRetryPolicy
which allow to retry the query, if node was down
and once it back, query will be succesfully finished
Fixes: #9284
Testing
java.io.IOException: Operation x10 on key(s) [32374e4d3230504b3030]: Data returned was not validated. Errors related to Scan operations are not reproducedPR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)