-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(longevity): restore contents of "longevity-mv-si-4days.jenkinsfile" #9163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit d722f0d ("test(tier1): Use streaming for longevity-mv-si-4days.jenkinsfile test", 2024-09-11) intended to do four things: (1) create an *unmodified* copy of "tier1/longevity-mv-si-4days.jenkinsfile" as "longevity/longevity-mv-si-4days.jenkinsfile"; (2) create a *modified* copy of the same "tier1/longevity-mv-si-4days.jenkinsfile" as "tier1/longevity-mv-si-4days-streaming.jenkinsfile", with the modification being the addition of "configurations/disable_rbno.yaml" to the test config; (3) redirect triggers from the original "tier1/longevity-mv-si-4days.jenkinsfile" to the modified copy created in (2); (4) remove the original "tier1/longevity-mv-si-4days.jenkinsfile". Step (1) was implemented incorrectly. The file created in step (1) is not an *unmodified* copy; today it is identical to the *modified* copy from step (2). Restore the actual original contents in "longevity/longevity-mv-si-4days.jenkinsfile". Signed-off-by: Laszlo Ersek <[email protected]>
lersek
added
backport/2024.2
Need backport to 2024.2
backport/6.2
backport/perf-v16
labels
Nov 7, 2024
2 tasks
fruch
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pehala
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the mistake
Thanks. |
This was referenced Nov 11, 2024
Merged
scylladbbot
added
backport/6.2-done
backport/2024.2-done
Commit backported to 2024.2
and removed
backport/6.2
backport/2024.2
Need backport to 2024.2
labels
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/perf-v16
backport/6.2-done
backport/2024.2-done
Commit backported to 2024.2
promoted-to-master
status/merge candidate
Item needs maintainer attention
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
PR pre-checks (self review)
backport
labels (commit d722f0d is contained bybranch-6.2
andbranch-perf-v16
, and it had been cherry-picked tobranch-2024.2
as commit 46b2a15)Reminders
sdcm/sct_config.py
)unit-test/
folder)