fix(manager): fix awscli installation on Ubuntu24 nodes #9154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikliapko
force-pushed
the
manager-fix-awscli-pip-install
branch
2 times, most recently
from
a51c39b to
9898124
Compare
mikliapko
changed the title
fruch
reviewed
Nov 7, 2024
mgmt_cli_test.py
Outdated
| apt update | ||
| apt install -y python3-pip | ||
| pip install awscli==1.18.140 | ||
| pip_break_system_packages = "--break-system-packages" if node.distro.is_ubuntu24 else "" |
There was a problem hiding this comment.
One more option is to use the environment variable for it, and you don't need a condition
There was a problem hiding this comment.
Agree, looks way better without this condition, fixed.
Retesting: https://jenkins.scylladb.com/job/scylla-staging/job/mikita/job/manager-master/job/ubuntu22-sanity-test/38/ (PASSED)
mikliapko
force-pushed
the
manager-fix-awscli-pip-install
branch
from
9898124 to
c9f2f5a
Compare
Changes: - break-system-packages allows pip to modify an externally-manager Python installation while installing package on Ubuntu24. - removed version specifying for the package since of compatibility issues with system-wide installation.
mikliapko
force-pushed
the
manager-fix-awscli-pip-install
branch
from
c9f2f5a to
7ec15dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes scylladb/scylla-manager#4105
Changes:
Testing
PR pre-checks (self review)
backportlabels