Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kafka-localstack): fix broken configuration file #7498

Merged
merged 1 commit into from
May 28, 2024
Merged

fix(kafka-localstack): fix broken configuration file #7498

merged 1 commit into from
May 28, 2024

Conversation

fruch
Copy link
Contributor

@fruch fruch commented May 28, 2024

name of a property was changed from version to source and was missed on one of the configurtion files introduce in #6946

and it started failing on test case linting right after the merge

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@fruch
fix(kafka-localstack): fix broken configuration file
97a193b 
name of a property was changed from `version` to `source`
and was missed on one of the configurtion files introduce in scylladb#6946

and it started failing on test case linting right after the merge
@fruch fruch added the backport/none Backport is not required label May 28, 2024
@fruch fruch requested review from vponomaryov and soyacz May 28, 2024 10:21
@fruch fruch mentioned this pull request May 28, 2024
Merged
2 tasks
vponomaryov
vponomaryov approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

soyacz
soyacz approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soyacz soyacz merged commit 1d5ab18 into scylladb:master May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyacz soyacz soyacz approved these changes

@vponomaryov vponomaryov vponomaryov approved these changes

Assignees

@fruch fruch

Labels
backport/none Backport is not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruch @vponomaryov @soyacz