Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(sct.py): Generate all backends for NemesisJobGenerator #7166

Merged

Conversation

k0machi
Copy link
Contributor

@k0machi k0machi commented Jan 29, 2024

This change adjusts create-nemesis-pipelines cli command to accept
multiple --backend arguments and makes it generate all supported
backends by omitting the option altogether.

The new option syntax is as follows:
./sct.py create-nemesis-pipelines --backend aws --backend gce [...]

Fixes #7106

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevent to this change (if needed)

This change adjusts `create-nemesis-pipelines` cli command to accept
multiple `--backend` arguments and makes it generate all supported
backends by omitting the option altogether.

The new option syntax is as follows:
`./sct.py create-nemesis-pipelines --backend aws --backend gce [...]`

Fixes scylladb#7106
@k0machi k0machi self-assigned this Jan 29, 2024
@k0machi k0machi requested review from fruch and soyacz January 29, 2024 11:05
@k0machi k0machi added backport/2024.1 Need backport to 2024.1 backport/5.4 Need backport to 5.4 labels Jan 29, 2024
@fruch
Copy link
Contributor

fruch commented Jan 29, 2024

@k0machi

and what about update the actual files ?

@k0machi
Copy link
Contributor Author

k0machi commented Jan 29, 2024

@fruch done.

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 5bb6e69 into scylladb:master Jan 29, 2024
5 checks passed
@fruch fruch added backport/2024.1-done Commit backported to 2024.1 backport/5.4-done Commit backported to 5.4 backport/2023.1-done Commit backported to 2023.1 labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/5.4-done Commit backported to 5.4 backport/5.4 Need backport to 5.4 backport/2023.1-done Commit backported to 2023.1 backport/2024.1-done Commit backported to 2024.1 backport/2024.1 Need backport to 2024.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-nemesis-pipelines should by default generate pipelines for all 3 clouds
2 participants