fix(get_nodetool_status): convert ipv6 to full format #7047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruch
added
backport/5.4
juliayakovlev
previously approved these changes
Jan 2, 2024
|
fixing unit test |
recent change to some java libraries used by nodetool is causing ipv6 to be presented as rfc5952 section-4 without leading zeros, and SCT was comapring those as string with other places we get addresses from. now we convert it to the full form, after getting it from nodetool, and still keep it as string Ref: https://www.rfc-editor.org/rfc/rfc5952#section-4
fruch
added
backport/2024.1-done
2 tasks
juliayakovlev
added a commit
to juliayakovlev/scylla-cluster-tests
that referenced
this pull request
May 21, 2024
The problem was found during IPv6 test. IPv6 was converted to full format when parse nodetool status result. This change was represented by scylladb#7047 But IPv6 address was not converted when collected info about nodes network interfaces (AWS). During checking nodes status, we compare between 'nodetool status' output and node address that kept in the network_interfaces object. It fails because the IPv6 address miss leading zeros. As result the test fails with errors 'Failed to find a node in cluster by IP' Fixes: scylladb#7447
juliayakovlev
added a commit
to juliayakovlev/scylla-cluster-tests
that referenced
this pull request
May 21, 2024
The problem was found during IPv6 test. IPv6 was converted to full format when parse nodetool status result. This change was represented by scylladb#7047 But IPv6 address was not converted when collected info about nodes network interfaces (AWS). During checking nodes status, we compare between 'nodetool status' output and node address that kept in the network_interfaces object. It fails because the IPv6 address miss leading zeros. As result the test fails with errors 'Failed to find a node in cluster by IP' Fixes: scylladb#7447
4 tasks
juliayakovlev
added a commit
to juliayakovlev/scylla-cluster-tests
that referenced
this pull request
May 21, 2024
The problem was found during IPv6 test. IPv6 was converted to full format when parse nodetool status result. This change was represented by scylladb#7047 But IPv6 address was not converted when collected info about nodes network interfaces (AWS). During checking nodes status, we compare between 'nodetool status' output and node address that kept in the network_interfaces object. It fails because the IPv6 address miss leading zeros. As result the test fails with errors 'Failed to find a node in cluster by IP' Also fix the same problem for peer and gossip output. Fixes: scylladb#7447
fruch
pushed a commit
that referenced
this pull request
May 21, 2024
The problem was found during IPv6 test. IPv6 was converted to full format when parse nodetool status result. This change was represented by #7047 But IPv6 address was not converted when collected info about nodes network interfaces (AWS). During checking nodes status, we compare between 'nodetool status' output and node address that kept in the network_interfaces object. It fails because the IPv6 address miss leading zeros. As result the test fails with errors 'Failed to find a node in cluster by IP' Also fix the same problem for peer and gossip output. Fixes: #7447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recent change to some java libraries used by nodetool is causing ipv6 to be presented as rfc5952 section-4 without leading zeros, and SCT was comapring those as string with other places we get addresses from.
now we convert it to the full form, after getting
it from nodetool, and still keep it as string
Ref: https://www.rfc-editor.org/rfc/rfc5952#section-4
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)