fix(nemesis): flush system_schema before doing encryption check #7036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruch
added
backport/5.4
fruch
force-pushed
the
flush_schema_before_KMS_check
branch
from
1d6ca4a to
936f336
Compare
roydahan
previously approved these changes
Jan 1, 2024
|
Flush helped, but still there are issues to address here, don't yet merge |
fruch
force-pushed
the
flush_schema_before_KMS_check
branch
from
9e37c87 to
94328ca
Compare
|
Now all issues were addressed. flush of the schema did helped, and we also need to take into account the fact tables are encrypted by default, so the check for clear, was wrong |
To avoid those errors, when checking a newly created table: ``` error processing arguments: could not load schema via schema-tables: std::runtime_error (Failed to find keyspace1.tmp_encrypted_table in schema tables) ```
since the data coming from `scylla sstable` might be with `Invalid control characters` which the default json parse doesn't allow
since we enabled `user_info_encryption` the `check_encryption_fact` in the end of the nemesis assumed it should be clear, but in fact it's still encrypeted cause of `user_info_encryption`
fruch
force-pushed
the
flush_schema_before_KMS_check
branch
from
94328ca to
1aa751b
Compare
|
@vponomaryov I've fix those according to you comments |
fruch
added
backport/2024.1-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid those errors, when checking a newly created table:
Fixes: #6825
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)