Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(featrues-testcases): disable manager on too small monitor nodes #7034

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Dec 31, 2023

those case doesn't need manager installed, and they are fine with having smaller monitor node, that manager (scylla) can't be installed on.

Testing

  • no testing is needed

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevent to this change (if needed)

those case doesn't need manager installed, and they are fine
with having smaller monitor node, that manager (scylla) can't be installed
on.
@fruch fruch added backport/5.4 Need backport to 5.4 backport/2024.1 Need backport to 2024.1 labels Dec 31, 2023
@fruch fruch requested review from soyacz and roydahan December 31, 2023 09:59
@fruch fruch merged commit 93260b2 into scylladb:master Dec 31, 2023
5 checks passed
@fruch fruch added backport/2024.1-done Commit backported to 2024.1 backport/5.4-done Commit backported to 5.4 labels Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/5.4-done Commit backported to 5.4 backport/5.4 Need backport to 5.4 backport/2024.1-done Commit backported to 2024.1 backport/2024.1 Need backport to 2024.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants