fix(is_enterprise): check command output applying logic #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since in cases we might have failure like the following: ``` Could not retrieve mirrorlist http://mirrorlist.centos.org/?release=7&arch=x86_64 &repo=os&infra=stock error was 14: curl#7 - "Failed connect to mirrorlist.centos.org:80; Operation now in progress" ``` we wrong assumed this should be enterpise and tried to install enterpise artifacts (which didn't existed)
vponomaryov
reviewed
Dec 19, 2023
| return "scylla-enterprise.x86_64" in result or "No matches found" not in result | ||
| result = self.remoter.sudo("yum search scylla-enterprise 2>&1", ignore_status=True) | ||
| if result.ok: | ||
| _is_enterprise = "scylla-enterprise.x86_64" in result.stdout or "No matches found" not in result.stdout |
There was a problem hiding this comment.
What about enterprise on Arm?
There was a problem hiding this comment.
I guess the other logic would cover it (i.e. No matches)
I just moved it around, the already available logic.
juliayakovlev
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since in cases we might have failure like the following:
we wrong assumed this should be enterpise and tried to install enterpise artifacts (which didn't existed)
PR pre-checks (self review)
backportlabelssdcm/sct_config.py)unit-test/folder)