Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dandelion io #483

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Dandelion io #483

merged 8 commits into from
Feb 1, 2024

Conversation

amoschoomy
Copy link
Contributor

@amoschoomy amoschoomy commented Jan 22, 2024

Closes #475

  • Updated scirpy.io from_dandelion and to_dandelion functions
  • Test fixture for dandelion is updated to reflect umi_count changes in dandelion
  • Specify sc-dandelion dependency to be at least 0.35 ( in accordance to dandelion changes)

@amoschoomy
Copy link
Contributor Author

awaiting dandelion package to be updated to 0.35

@amoschoomy
Copy link
Contributor Author

amoschoomy commented Feb 1, 2024

Dandelion 0.35 also will integrate umi_count changes as mentioned in #487 (comment) so the test_io.py have also been updated as well

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d776d01) 81.04% compared to head (22c2f27) 81.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
- Coverage   81.04%   81.00%   -0.04%     
==========================================
  Files          49       49              
  Lines        3972     3959      -13     
==========================================
- Hits         3219     3207      -12     
+ Misses        753      752       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amoschoomy amoschoomy marked this pull request as ready for review February 1, 2024 05:53
@amoschoomy
Copy link
Contributor Author

@grst this PR is ready to be reviewed

@grst grst merged commit acc228e into scverse:main Feb 1, 2024
11 checks passed
@grst
Copy link
Collaborator

grst commented Feb 1, 2024

Thanks, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dandelion interoperability
2 participants