Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Merge blt+bltu circuits #792

Merged
merged 11 commits into from
Dec 30, 2024
Merged

feat: Merge blt+bltu circuits #792

merged 11 commits into from
Dec 30, 2024

Conversation

varun-doshi
Copy link
Contributor

Ref #651

@varun-doshi
Copy link
Contributor Author

a few questions:

  • should i remove the blt.rs and bltu.rs files
  • the name b_circuit is very ambiguous...what should i name this file?

hero78119
hero78119 reviewed Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and contribution! just left few comments & answer questions

ceno_zkvm/src/instructions/riscv/branch/b_circuit.rs Outdated Show resolved Hide resolved
hero78119
hero78119 reviewed Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go 👍

ceno_zkvm/src/gadgets/is_lt.rs Outdated Show resolved Hide resolved
ceno_zkvm/src/gadgets/is_lt.rs Outdated Show resolved Hide resolved
ceno_zkvm/src/gadgets/signed_ext.rs Outdated Show resolved Hide resolved
@hero78119
Copy link
Collaborator

in ci, there are one indicated error. please run cargo fmt --all --check locally and fixed, tks

hero78119
hero78119 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hero78119 hero78119 enabled auto-merge December 30, 2024 15:11
@hero78119 hero78119 added this pull request to the merge queue Dec 30, 2024
Merged via the queue into scroll-tech:master with commit 1d7818e Dec 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hero78119 hero78119 Awaiting requested review from hero78119

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varun-doshi @hero78119