Suggestions for [Feat] Calculate proof size and number of hashes #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from suggestions for #712
| @@ -70,7 +70,7 @@ fn fibonacci_prove(c: &mut Criterion) { | |||
| "max_steps = {}, proof size = {}, hashes count = {}", | |||
| max_steps, | |||
| serialize_size, | |||
| stat_recorder.borrow().field_appended_num | |||
| stat_recorder.into_inner().field_appended_num | |||
There was a problem hiding this comment.
This .into_inner() enlists the borrow checker into making sure that no one else holds any access to our stat_recorder refcell anymore. Specifically, this .into_inner() only works when the borrowing in BasicTranscriptWitStat::new(&stat_recorder, b"riscv"); is done.
Because of this, we don't need the manual drop anymore.
mpcs/benches/basefold.rs
Outdated
| let proof = Pcs::open(&pp, &poly, &comm, &point, &eval, &mut transcript).unwrap(); | ||
|
|
||
| group.bench_function(BenchmarkId::new("open", format!("{}", num_vars)), |b| { | ||
| b.iter_batched( | ||
| || transcript_for_bench.clone(), |
There was a problem hiding this comment.
We remove the need to clone here in #770
That PR is somewhat independent of yours, and we can merge it first, making the diff here smaller.
transcript/src/basic.rs
Outdated
| @@ -32,15 +32,15 @@ impl<E: ExtensionField> Transcript<E> for BasicTranscript<E> { | |||
| } | |||
|
|
|||
| fn read_challenge(&mut self) -> Challenge<E> { | |||
| // notice `from_bases` and `from_limbs` has the same behavior but | |||
| @@ -179,11 +179,9 @@ fn test_rw_lk_expression_combination() { | |||
| &verifier_challenges, | |||
| ) | |||
| .expect("verifier failed"); | |||
|
|
|||
| drop(v_transcript); | |||
There was a problem hiding this comment.
.into_inner() sort-of does the job that the manual drop used to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some suggestions for #712
This builds on #770 and the diff will get smaller, once #770 is in master.
The main idea here is to remove the need to have a reference count and also simultaneously remove the need for a manual drop. We enlist the borrow checker's help to make sure that we only show the statistics, once everything has been added up. (No more
sync_statnecessary, either.)