Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix job start #1314

Merged
merged 5 commits into from
Dec 20, 2024
Merged

fix: Fix job start #1314

merged 5 commits into from
Dec 20, 2024

Conversation

minghay
Copy link
Contributor

@minghay minghay commented Dec 19, 2024

Context

When starting a new event from a job in the V2 job UI, the event is started from ~commit instead of the selected job.

Objective

  1. Update the title on the start event button to better capture that an event will be started from the event
  2. Update the start modal to provide the job information
  3. Update the post body to handle a couple new scenarios

References

screwdriver-cd/screwdriver#3200

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@VonnyJap VonnyJap merged commit cf22474 into master Dec 20, 2024
1 check passed
@VonnyJap VonnyJap deleted the fix-job-start branch December 20, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants