Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3227): Show download button when the flag is false #1215

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

kumada626
Copy link
Contributor

Context

#1206 has a minor bug with the if-else conditions in the template which causes the download button to go missing when feature flag is false.

Objective

Fixes the missing download button when feature flag is false.

References

screwdriver-cd/screwdriver#3227

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link
Member

@tkyi tkyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♀️ thank you sorry

@tkyi tkyi merged commit 05340d8 into master Nov 1, 2024
2 checks passed
@tkyi tkyi deleted the show-dl-button branch November 1, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants