feat(3211): Build detail view - Hide steps and logs for virtual builds #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghay
previously approved these changes
Oct 22, 2024
tkyi
previously approved these changes
Oct 22, 2024
sagar1312
force-pushed
the
sagar1312-feat-3211-virtual_build_detail
branch
from
db5577d to
6f26683
Compare
tkyi
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For virtual jobs, builds are created but never executed. API marks status of such builds as "SUCCESS" when those are eligible for execution.
API also sets "Skipped execution of the virtual job" and "INFO" as
statusMessageandstatusMessageTyperespectively.In the UI, the build detail view shows that the was a failure in
sd-setup-initstep. This gives a false impression that the build got executed and the step failed.Before
Objective
We need to make below changes in the build details view
statusMessageType. In the case of virtual jobs, the message "Skipped execution of the virtual job" should be displayed as information.After
References
screwdriver-cd/screwdriver#3211
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.