Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Screwdriver style mixin for Bootstrap buttons #1082

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

minghay
Copy link
Contributor

@minghay minghay commented Jul 4, 2024

Context

Create a style mixin for bootstrap buttons so that we can incrementally adopt a consistent standard on button styles on the new UI.

Objective

Setting the primary and outline button styles based on bootstrap ember buttons (i.e., BsButton components).

Primary button:
Screenshot 2024-07-03 at 17-06-53 New Pipeline Events Show
Primary button hover state:
Screenshot 2024-07-03 at 17-07-07 New Pipeline Events Show
Primary button as outline style (note that the button background color is actually transparent hence the slight grey color in the attached screenshot):
Screenshot 2024-07-03 at 17-08-15 New Pipeline Events Show
Primary button as outline hover state:
Screenshot 2024-07-03 at 17-08-24 New Pipeline Events Show

References

screwdriver-cd/screwdriver#3200

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@tkyi tkyi merged commit bcf7f11 into master Jul 4, 2024
2 checks passed
@tkyi tkyi deleted the buttons-style-mixin branch July 4, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants