Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v2 secrets route #1072

Merged
merged 5 commits into from
Jun 27, 2024
Merged

feat: add v2 secrets route #1072

merged 5 commits into from
Jun 27, 2024

Conversation

adong
Copy link
Contributor

@adong adong commented Jun 21, 2024

Context

Add secrets route to v2.

Objective

Screenshot:
image

References

screwdriver-cd/screwdriver#3200

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@minghay
Copy link
Contributor

minghay commented Jun 21, 2024

Can you try using Glimmer components? I think it's best to take the opportunity now with the new UI work to migrate over to Glimmer components.

app/v2/pipeline/secrets/route.js Outdated Show resolved Hide resolved
app/v2/pipeline/secrets/controller.js Outdated Show resolved Hide resolved
app/v2/pipeline/template.hbs Outdated Show resolved Hide resolved
@adong adong force-pushed the adong/secrets-tab branch from 22544a5 to 59af799 Compare June 27, 2024 16:30
@adong adong merged commit e2e6035 into master Jun 27, 2024
2 checks passed
@adong adong deleted the adong/secrets-tab branch June 27, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants