Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default parameter icon #1069

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix: Default parameter icon #1069

merged 2 commits into from
Jun 19, 2024

Conversation

minghay
Copy link
Contributor

@minghay minghay commented Jun 19, 2024

Context

#1068 had missed an existing feature where default values are noted by an icon. This adds that functionality back in. The default value is shown when the icon is moused-over.

Objective

Add in icon with hover over to indicate that the parameter has a default value that is different that the current value in the text input
Screenshot 2024-06-18 at 17-44-00 New Pipeline Events Show
mouse hover

References

screwdriver-cd/screwdriver#3200

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@minghay minghay merged commit 80776a8 into master Jun 19, 2024
2 checks passed
@minghay minghay deleted the default-parameter-icon branch June 19, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants