Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New look and feel for event page #1040

Merged
merged 16 commits into from
May 4, 2024
Merged

feat: New look and feel for event page #1040

merged 16 commits into from
May 4, 2024

Conversation

adong
Copy link
Contributor

@adong adong commented Apr 18, 2024

Context

Modernize event page:

  1. Add navigation from old ui to new ui and vice versa to sd admins
  2. Move options from top to left side
  3. Move events/pull-requests from right side to left side along combining jobs(job-list-view)
  4. implemented routing rejection for non-sdadmin users
  5. rename routes from new/ to v2/

image

Pending:

  1. Change the event-list view layout from right to left
  2. Change the workflow-graph view layout from left to right
  3. Tests are not written until logics are finalized.

Objective

Screenshot:

image

image

References

screwdriver-cd/screwdriver#3200

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@adong adong changed the title WIP: New look and feel for event page [skip ci]: New look and feel for event page Apr 18, 2024
@adong adong changed the title [skip ci]: New look and feel for event page feat: New look and feel for event page Apr 18, 2024
@VonnyJap
Copy link
Member

VonnyJap commented Apr 25, 2024

tests failed, expected?
can we not use naming of file with newui prefix? prefer something like versioning or theme name.

@VonnyJap VonnyJap requested review from minghay and sagar1312 May 2, 2024 23:45
app/styles/new-ui.scss Outdated Show resolved Hide resolved
app/v2/route.js Outdated Show resolved Hide resolved
app/components/app-header/component.js Outdated Show resolved Hide resolved
app/components/newui-pipeline-nav/component.js Outdated Show resolved Hide resolved
app/router.js Outdated Show resolved Hide resolved
app/router.js Show resolved Hide resolved
@tkyi tkyi merged commit ec03d55 into master May 4, 2024
2 checks passed
@tkyi tkyi deleted the adong/new-ui branch May 4, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants