feat(3087): Show that events was executed using Pipeline Access Token #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-oksaku
commented
Apr 25, 2024
| @@ -79,6 +79,11 @@ module.exports = () => ({ | |||
|
|
|||
| if (creator) { | |||
| payload.creator = creator; | |||
| } else if (scope.includes('pipeline')) { | |||
There was a problem hiding this comment.
Creator setting is in payload, then it gets preference over "Pipeline Access Token".
yakanechi
approved these changes
Apr 25, 2024
yk634
approved these changes
Apr 25, 2024
itleigns
approved these changes
Apr 25, 2024
tkyi
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, someone in pipeline admins is displayed in "Started by" when user executes events with pipeline access token.
Hence the user cannot know whether the event was executed by the user or by the token.
Objective
Display "Started by: Pipeline Access Token" when the event executed with pipeline access token.
References
#3087
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.