fix(3225): organize the return values of _parseHook [1] #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, the
_parseHook
method returns Object or null or throw Error.However, their return values are not properly conditioned.
Objective
Organize the return values by the following:
scm
is correct and Screwdriver do actions with the webhook (e.g.push
event)scm
is correct and Screwdriver do nothing (e.g.delete
event)scm
is not correctThen we can handle whether the webhook is correct or not at here.
References
Issue
PR
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.