fix(3089): restore k8s hostname into build stats data #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c067382.
kumada626
approved these changes
Apr 30, 2024
tkyi
approved these changes
Apr 30, 2024
|
🎉 This PR is included in version 15.0.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Reverts #186
Objective
If the launcher fails during the initialization container setup, the node information for the build execution will not be updated. Rolling back this commit should enable the executor to update the node that the build is scheduled to run on, while still allowing the launcher to update the information afterward. If the hostname remains unchanged, the action should be idempotent regardless.
References
screwdriver-cd/screwdriver#3089
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.