Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structured error logging with cause #99

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

wagpa
Copy link
Contributor

@wagpa wagpa commented Apr 28, 2024

Changes

  • rename fetch_image_bytes to fetch_bytes
  • use structured logging with error cause

Previously, dns errors and the like would only show a generic error. Now the log includes the source(s) indicating, for example, the dns error and message.

@wagpa wagpa requested a review from scrayos April 28, 2024 10:23
@wagpa wagpa added the enhancement New feature or request label Apr 28, 2024
@scrayos scrayos merged commit ebff3e5 into main Apr 28, 2024
4 checks passed
@scrayos scrayos deleted the dev/mojang-structured-logging branch April 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants