Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new containerProbe type exec for command execution #114

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions samples/score-full.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ containers:
httpGet:
port: 8080
path: /livez
exec:
command:
- /bin/curl
- -f
- "http://localhost:8080/livez"
readinessProbe:
httpGet:
host: 127.0.0.1
Expand Down
22 changes: 19 additions & 3 deletions score-v1b1.json
Original file line number Diff line number Diff line change
Expand Up @@ -338,13 +338,29 @@
},
"containerProbe": {
"type": "object",
"required": [
"httpGet"
],
"description": "The probe may be defined as either http, command execution, or both when the deployment runtime supports one and not the other.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the spec define which one takes precedence if both are supported - or should that be implementation specific?

"additionalProperties": false,
"properties": {
"httpGet": {
"$ref": "#/$defs/httpProbe"
},
"exec": {
"$ref": "#/$defs/execProbe"
}
}
},
"execProbe": {
"description": "An executable health probe.",
"type": "object",
"additionalProperties": false,
"required": ["command"],
"properties": {
"command": {
"description": "The command and arguments to execute within the container.",
"type": "array",
"items": {
"type": "string"
}
}
}
},
Expand Down
Loading