-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new containerProbe type exec for command execution #114
base: main
Are you sure you want to change the base?
feat: Add new containerProbe type exec for command execution #114
Conversation
9f70208
to
14d4942
Compare
Signed-off-by: Ben Meier <[email protected]>
Signed-off-by: Ben Meier <[email protected]>
Signed-off-by: Ben Meier <[email protected]>
Signed-off-by: Ben Meier <[email protected]>
Signed-off-by: Ben Meier <[email protected]>
Signed-off-by: Ben Meier <[email protected]>
fab392a
to
935b9e4
Compare
Signed-off-by: Ben Meier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One open question: is choice of which probe to use if both supported implementation specific?
"required": [ | ||
"httpGet" | ||
], | ||
"description": "The probe may be defined as either http, command execution, or both when the deployment runtime supports one and not the other.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the spec define which one takes precedence if both are supported - or should that be implementation specific?
This fixes #113 to add the exec type container probe option. This is equivalent to:
exec
)Most other container runtimes (fly.io, gcp cloud run, ECS app, azure container app) all use http/grpc/tcp health probes instead, presumably because these are cheaper for the dataplane to execute reliably. However since the reference implementations of Score support exec probes, we can add this as an option.
I think it's important we allow both types to be specified for a probe so that the runtime can pick the one it supports and still get the right final behavior.
Examples:*
score-compose can convert:
to
score-k8s can convert:
into:
Since the http variant of the probe is supported and cheaper to run.