[FIX] Test data caching and unzipping #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is problems currently when test data starts to download but then an error occurs in the code or the workflow. It was hard to implement in the current form of the
load_test_data
workflow. I revamped the structure that handled the cache, using CRUD operations (create, read, update, delete), so every corner cases are correctly handled by implementation. There aretry/catch
everywhere to make sure that the cache doesn't get polluted, so we should be ok from now on.For reference, it's kind of what I implemented in Scilpy for
fetch_data
, but better 😛Also, in addition :
pdiff
and configured the devcontainer to print the differences in nf-test results betterBug category
Describe the bug
Bad data gets stuck in cache.
Steps to reproduce the bug
~/.local/share/nf-test-archives
)