Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update registration subworkflows and modules #62

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

AlexVCaron
Copy link
Collaborator

Continuation of #25

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

subworkflow/registration:

  • add synthregistration optionality to subworkflow
  • add specific test for synthregistration

modules/synthregistration:

  • change output structure to tuple transfo_image containing both transforms
  • add python package access.

module/convert:

  • add optionality to affine conversion. If no affine is provided, skips conversion. Synthmorph output include affine initialization in its deform output.
  • change output order

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

arnaudbore
arnaudbore previously approved these changes Dec 2, 2024
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick questions and GTG !

.branch{
t1w: it.simpleName == "T1w"
b0: it.simpleName == "b0"
dti: it.simpleName == "dti"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need it here.


cat <<-END_VERSIONS > versions.yml
"${task.process}":
Freesurfer: 7.4
Freesurfer: 7.4.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you have different soft and versions here ? Generic way of getting the version also.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for synthmorph yet, no mechanism in the container sadly. I aligned both versions for now

@AlexVCaron
Copy link
Collaborator Author

AlexVCaron commented Dec 2, 2024

Let's wait a bit. I found an inconsistency with the last two conditions in the subworkflow. There should not be a check on ch_metric directly, it's bound to fail as we said. I rewrote the section so it's channels doing the job of selecting either anatotodwi or the classical ants SyN script. In test, I will push shortly

@arnaudbore arnaudbore added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit b0aa9b0 Dec 5, 2024
17 checks passed
@AlexVCaron AlexVCaron deleted the revert-57-revert-25-fix-synthregistration branch December 6, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants