-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Update registration subworkflows and modules #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick questions and GTG !
.branch{ | ||
t1w: it.simpleName == "T1w" | ||
b0: it.simpleName == "b0" | ||
dti: it.simpleName == "dti" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need it here.
|
||
cat <<-END_VERSIONS > versions.yml | ||
"${task.process}": | ||
Freesurfer: 7.4 | ||
Freesurfer: 7.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you have different soft and versions here ? Generic way of getting the version also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for synthmorph yet, no mechanism in the container sadly. I aligned both versions for now
Let's wait a bit. I found an inconsistency with the last two conditions in the subworkflow. There should not be a check on |
Continuation of #25
Type of improvement
Describe your improvement
subworkflow/registration:
modules/synthregistration:
module/convert:
Checklist before requesting a review