Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update topup_eddy subworkflows and eddy module #61

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

AlexVCaron
Copy link
Collaborator

Continuation of #26

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

subworkflow/topup_eddy:

copy alex's changes for tractoflow

module/preproc/eddy:

  • change bval output name: had problem further in the flow caused by lack ox fil extension

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !

Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! The comments you added make following the channels straightforward! 💯

@arnaudbore arnaudbore added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 9ed218f Dec 2, 2024
19 checks passed
@AlexVCaron AlexVCaron deleted the revert-58-revert-26-fix-module-eddy branch December 6, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants