Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update buggy extension package #3

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

AlexVCaron
Copy link
Collaborator

Bug category

  • Critical (some functionalities is not working at all)
  • Major (something is not working as expected)
  • Minor (something but could be improved)
  • Trivial (documentation needs correcting and other non-functional issues)

Describe the bug

Installations of extensions using the pack can't complete because of buggy extensions. This PR removes them and update the packages with newer improves ones. The PR also removes old node dependencies that were installed in the devcontainer to improve build time.

@AlexVCaron
Copy link
Collaborator Author

AlexVCaron commented Sep 17, 2024

@gagnonanthony @arnaudbore If any of you can try building the devcontainer and verify that at the end of the build, those two extensions are installed :

  • nf-neuro.test-data-treeview (Test Data Treeview)
  • nf-neuro.nf-neuro-extensionpack (nf-neuro extension pack)

To check that extension installation has completed, check that :

  • there is no more activity from the extensions store (Ctrl+Shift+X)
  • there is not much happening in View>Output>Extension Host (Remote), except from an error from KorbinianEckstein.niivue and one undefined

If that's good, approve the PR, and we merge !

Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my end, everything seems fine! There aren't any activities in the extensions tab, and nothing other than the NiiVue error in the output!

@AlexVCaron AlexVCaron added this pull request to the merge queue Sep 17, 2024
Merged via the queue into scilus:main with commit 4a905d1 Sep 17, 2024
9 checks passed
@AlexVCaron AlexVCaron deleted the fix/devcontainer_extensions branch September 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants