Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Update image/resample #22

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[ENH] Update image/resample #22

merged 2 commits into from
Oct 30, 2024

Conversation

gagnonanthony
Copy link
Contributor

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Update image/resample with Alex's changes + update tests. #14

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

@gagnonanthony gagnonanthony added the enhancement New feature or request label Oct 25, 2024
@gagnonanthony gagnonanthony self-assigned this Oct 25, 2024
arnaudbore
arnaudbore approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

ThoumyreStanislas
ThoumyreStanislas approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ThoumyreStanislas ThoumyreStanislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arnaudbore arnaudbore added this pull request to the merge queue Oct 30, 2024
Merged via the queue into scilus:main with commit 0ae1ede Oct 30, 2024
17 checks passed
@gagnonanthony gagnonanthony deleted the update_image branch October 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThoumyreStanislas ThoumyreStanislas ThoumyreStanislas approved these changes

@arnaudbore arnaudbore arnaudbore approved these changes

@Manonedde Manonedde Awaiting requested review from Manonedde

Assignees

@gagnonanthony gagnonanthony

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gagnonanthony @arnaudbore @ThoumyreStanislas