Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a space when when glueing default solr params to end of search #535

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

cziaarm
Copy link
Collaborator

@cziaarm cziaarm commented Apr 17, 2024

Story

Look up of collections never get results

Refs #451

This is due to the catalog controller building a solr query search string that looks like this:

...add_info_tesim collection_tesimtitle_tesim description_tesim all_text_timv

So the title lookup is doomed to fail

Expected Behavior Before Changes

autocomplete lookup a collection when adding a work will not find any results

Expected Behavior After Changes

autocomplete lookup a collection when adding a work will find expected results

Screenshots / Video

Notes

Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, we had to fix this somewhere as well 😓

@cziaarm
Copy link
Collaborator Author

cziaarm commented Apr 17, 2024

These tests have started failing today

rspec ./spec/features/create_image_spec.rb:41

rspec ./spec/features/create_generic_work_spec.rb:42

Not really sure why...

@cziaarm cziaarm merged commit 33375c8 into main Apr 26, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants