Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that viewers show rather than thumbnails #890

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Nov 13, 2024

Story

Refs:

In the case of a split work, :pdf? needs to be included in the methods checked on a presenter.
In the case of a work that isn't split, Valkyrie has changed the term we use to check for a .pdf suffix. It appears that we do not fill in the label term. If characterization fails and we fall back to looking for a pdf, we needed to look in the right location.

Expected Behavior Before Changes

When PDF.js is selected via flipper and a work has been split, it sometimes just shows a thumbnail.
When PDF.js is selected via flipper and work is not split, it sometimes just shows a thumbnail.

Expected Behavior After Changes

In new (valkyrie) resources, resources converted from Fedora, and works still in Fedora:

  • When PDF.js is selected via flipper and a work has been split, it shows the UV
  • When PDF.js is selected via flipper and a work is not split, it shows the PDF in PDF.js

Screenshots / Video

Both of these originally showed thumbnails only

Screenshot 2024-11-13 at 2 51 37 PM

Screenshot 2024-11-13 at 2 47 01 PM

Notes

@laritakr laritakr merged commit 6162b6c into main Nov 13, 2024
6 checks passed
@laritakr laritakr deleted the more-viewer-fixes branch November 13, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants