Ensure that viewers show rather than thumbnails #890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Refs:
In the case of a split work, :pdf? needs to be included in the methods checked on a presenter.
In the case of a work that isn't split, Valkyrie has changed the term we use to check for a
.pdf
suffix. It appears that we do not fill in the label term. If characterization fails and we fall back to looking for a pdf, we needed to look in the right location.Expected Behavior Before Changes
When PDF.js is selected via flipper and a work has been split, it sometimes just shows a thumbnail.
When PDF.js is selected via flipper and work is not split, it sometimes just shows a thumbnail.
Expected Behavior After Changes
In new (valkyrie) resources, resources converted from Fedora, and works still in Fedora:
Screenshots / Video
Both of these originally showed thumbnails only
Notes