-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF.js not rendering when it should #880
Comments
# Story Refs: - #880 - #881 In the case of a split work, :pdf? needs to be included in the methods checked on a presenter. In the case of a work that isn't split, Valkyrie has changed the term we use to check for a `.pdf` suffix. It appears that we do not fill in the label term. If characterization fails and we fall back to looking for a pdf, we needed to look in the right location. # Expected Behavior Before Changes When PDF.js is selected via flipper and a work has been split, it sometimes just shows a thumbnail. When PDF.js is selected via flipper and work is not split, it sometimes just shows a thumbnail. # Expected Behavior After Changes In new (valkyrie) resources, resources converted from Fedora, and works still in Fedora: - When PDF.js is selected via flipper and a work has been split, it shows the UV - When PDF.js is selected via flipper and a work is not split, it shows the PDF in PDF.js # Screenshots / Video <details> <summary>Both of these originally showed thumbnails only</summary> ![Screenshot 2024-11-13 at 2 51 37 PM](https://github.com/user-attachments/assets/0dbc51c1-a365-4b1a-a79d-3ce33d9d718d) ![Screenshot 2024-11-13 at 2 47 01 PM](https://github.com/user-attachments/assets/43050ab0-1783-4136-bd53-321cff20efc9) </details> # Notes
I'm seeing some unsplit works (uploaded before the cutover) are failing to show the PDF in the PDF.js viewer, but the thumbnail is displaying in the UV. So weird! |
Dropping a comment on behavior I'm seeing. A couple weeks ago when the team ran our big OAI import post cutover, the new works showed in PDF.js. Today I'm running a big import (but small compared to that OAI feed) and I'm seeing thumbnails only. The viewer isn't rendering. The import is still going, so maybe the viewer is just slow? But that is not how it behaved before the cutover. Before recent changes, PDF.js would render within a few seconds of a file attaching to a work. Generally I only had to refresh once. Here's the first work that came from the recent import. It was ingested over 20 hours ago, and it shows only a thumbnail. And the importer still in progress: I definitely want to check this again to confirm the viewer is still missing, but for now, here's a comment to mark what i see. |
This seems to be a case of re-ingesting things that were previously ingested... the link you provided was ingested a year ago, by the dates on the child works. The child works will still be in fedora. I haven't checked the parent, so I don't know what happens with the reingest... I assume it's in Valkyrie now. Because there are child works, it tries to use the universal viewer rather than the PDFjs viewer. And the universal viewer can't handle the mixed situations well. In short, I think we can expect to have viewer issues until we complete the migration to Valkyrie. |
Summary
example:
https://adl.b2.adventistdigitallibrary.org/concern/published_works/20218025_ellen_white_and_her_work
Acceptance Criteria
Screenshots or Video
Testing Instructions
To be filled out by dev
Notes
The text was updated successfully, but these errors were encountered: