feat(postgres-backup-s3): update AWS CLI to v2; allow support for mul… #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiple databases; allow support for defining sensitive env vars in files (eg Docker secrets)
AWS CLI updated to v2; python removed; glibc added
Added support for multiple databases (note POSTGRES_DATABASE env var is deprecated and replaced by POSTGRES_DATABASES) -- this means this version of the docker image is not backward-compatible with previosu releases.
Added support for _FILE env vars for sensitive values. This allows using the image with Docker secrets.
For example,
```
service:
postgres-backup
environment:
POSTGRES_PASSWORD_FILE=/run/secrets/postgres-password
...
secrets:
- postgres-password
```
|
@opichon could you rebase this on master so I could take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tiple databases; allow support for defining sensitive env vars in files (eg Docker secrets)
AWS CLI updated to v2; python removed; glibc added
Added support for multiple databases (note POSTGRES_DATABASE env var is deprecated and replaced by POSTGRES_DATABASES) -- this means this version of the docker image is not backward-compatible with previosu releases.
Added support for _FILE env vars for sensitive values. This allows using the image with Docker secrets.
For example,