add sbt 2.x cross build setting #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
reviewed
Oct 19, 2024
| @@ -4,7 +4,9 @@ import java.io.OutputStreamWriter | |||
| import java.nio.file.Path | |||
|
|
|||
| import sbt.Keys._ | |||
| import sbt._ | |||
| // format: off | |||
There was a problem hiding this comment.
why is this necessary? if this is scala3 syntax, better to modify scalafmt configuration, no?
There was a problem hiding this comment.
Lines 23 to 24 in 0344d19
without this comment expand import
- import sbt.{given, _}
+ import sbt._
+ import sbt.givenbut error if Scala 2.12
There was a problem hiding this comment.
is this is an unreported bug in scalafmt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.