Precompile a regex in hot code #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
requested review from
Friendseeker and
eed3si9n
and removed request for
Friendseeker
Friendseeker
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Thanks!
I was thinking about the cost of regex overhead in #1324 (comment), but this particular optimization slipped my mind...
|
github is telling me 500 to view the diff, but from the title I'll say 🎉 retronym. I'm so glad retronym is on our side, as they say in the superhero universe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.