fix: Remove Meta from Model
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyright 1.1.339 enabled reportIncompatibleVariableOverride=true as part of new default "standard" mode. https://github.com/microsoft/pyright/releases/tag/1.1.339 This leads to > error: "Meta" overrides symbol of same name in class "Model" At runtime, models do not have `Meta` if it's not defined, so it's safe to remove it.
|
This still leaves the problem of inheriting from abstract models, but probably we cannot fix it at type stubs level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyright 1.1.339 enabled reportIncompatibleVariableOverride=true as part of new default "standard" mode.
https://github.com/microsoft/pyright/releases/tag/1.1.339
This leads to
At runtime, models do not have
Metaif it's not defined, so it's safe to remove it.