Improve BaseManager, Manager types #205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a series of improvements to methods and properties of
BaseManager
andManager
:BaseManager.deconstruct()
: Most of the values in the return tuple can be null (see implementation)BaseManager.from_queryset()
:queryset_class
is now generic, and the return type is made more specific (see implementation). This allows code like this to receive type information:BaseManager._get_queryset_methods()
: Return dictionary values are functions (see implementation).Manager._queryset_class
: This property is assigned dynamically byBaseManager.from_queryset()
(see implementation)