use const auto& in suggested places

samp-incognito · Jan 14, 2023 · 3191a61 · 3191a61
1 parent 434d84c
commit 3191a61
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/grid.cpp b/src/grid.cpp
@@ -580,7 +580,7 @@ void Grid::processDiscoveredCellsForPlayer(Player &player, std::vector<SharedCel
 		{
 			if (o->second->cell)
 			{
-				auto d = discoveredCells.find(o->second->cell->cellId);
+				const auto& d = discoveredCells.find(o->second->cell->cellId);
 				if (d != discoveredCells.end())
 				{
 					o = player.visibleCell->objects.erase(o);
@@ -604,7 +604,7 @@ void Grid::processDiscoveredCellsForPlayer(Player &player, std::vector<SharedCel
 		{
 			if (c->second->cell)
 			{
-				auto d = discoveredCells.find(c->second->cell->cellId);
+				const auto& d = discoveredCells.find(c->second->cell->cellId);
 				if (d != discoveredCells.end())
 				{
 					c = player.visibleCell->checkpoints.erase(c);
@@ -628,7 +628,7 @@ void Grid::processDiscoveredCellsForPlayer(Player &player, std::vector<SharedCel
 		{
 			if (r->second->cell)
 			{
-				auto d = discoveredCells.find(r->second->cell->cellId);
+				const auto& d = discoveredCells.find(r->second->cell->cellId);
 				if (d != discoveredCells.end())
 				{
 					r = player.visibleCell->raceCheckpoints.erase(r);
@@ -652,7 +652,7 @@ void Grid::processDiscoveredCellsForPlayer(Player &player, std::vector<SharedCel
 		{
 			if (m->second->cell)
 			{
-				auto d = discoveredCells.find(m->second->cell->cellId);
+				const auto& d = discoveredCells.find(m->second->cell->cellId);
 				if (d != discoveredCells.end())
 				{
 					m = player.visibleCell->mapIcons.erase(m);
@@ -676,7 +676,7 @@ void Grid::processDiscoveredCellsForPlayer(Player &player, std::vector<SharedCel
 		{
 			if (t->second->cell)
 			{
-				auto d = discoveredCells.find(t->second->cell->cellId);
+				const auto& d = discoveredCells.find(t->second->cell->cellId);
 				if (d != discoveredCells.end())
 				{
 					t = player.visibleCell->textLabels.erase(t);
@@ -700,7 +700,7 @@ void Grid::processDiscoveredCellsForPlayer(Player &player, std::vector<SharedCel
 		{
 			if (a->second->cell)
 			{
-				auto d = discoveredCells.find(a->second->cell->cellId);
+				const auto& d = discoveredCells.find(a->second->cell->cellId);
 				if (d != discoveredCells.end())
 				{
 					a = player.visibleCell->areas.erase(a);

diff --git a/src/utility/misc.h b/src/utility/misc.h
@@ -101,7 +101,7 @@ namespace Utility
 	template<typename T>
 	inline int getFirstValueInContainer(const std::unordered_set<T> &container)
 	{
-		auto i = container.begin();
+		const auto& i = container.begin();
 		if (i != container.end())
 		{
 			return *i;