Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitemap overflow fix #83

Closed
wants to merge 5 commits into from
Closed

Sitemap overflow fix #83

wants to merge 5 commits into from

Conversation

DarkSilence
Copy link

That's my implementation for a fix for issues #82 and #81
I'm not quite sure about my approach on line 202. Could you check it please.

@DarkSilence
* flush function call typo
5ab5a97 
* proposition for a fix for a bug which causes a sitemap to overflow when size limit is reached
@DarkSilence
* \n were replaced with PHP_EOL
bb9cd93
@DarkSilence
* different approach to a problem with a sitemap overflowing
875ae7a
samdark
samdark reviewed Jan 10, 2022
View reviewed changes
Sitemap.php Outdated Show resolved Hide resolved
samdark
samdark reviewed Jan 26, 2022
View reviewed changes
Sitemap.php Outdated Show resolved Hide resolved
samdark
samdark reviewed Jan 26, 2022
View reviewed changes
Sitemap.php Outdated Show resolved Hide resolved
@mougrim
Copy link
Contributor

mougrim commented Aug 13, 2023

@samdark @DarkSilence, Hi!
What is needed for merge fix? Do you need some help here?
I have the same issue:

PHP Fatal error:  Uncaught OverflowException: The buffer size is too big for the defined file size limit in vendor/samdark/sitemap/Sitemap.php:234
Stack trace:
#0 vendor/samdark/sitemap/Sitemap.php(199): samdark\sitemap\Sitemap->flush()
#1 vendor/samdark/sitemap/Sitemap.php(212): samdark\sitemap\Sitemap->finishFile()

@samdark
Copy link
Owner

samdark commented Aug 18, 2023

Yes.

Need to verify it works and works correctly.

@mougrim
Copy link
Contributor

mougrim commented Sep 8, 2023

Hello!
Looks like it doesn't fix OverflowException, I'm preparing separated MR.

@mougrim mougrim mentioned this pull request Sep 10, 2023
Merged
@samdark samdark closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkSilence @mougrim @samdark