Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo in a flush() function call #82

Open
DarkSilence opened this issue Jan 10, 2022 · 1 comment
Open

A typo in a flush() function call #82

DarkSilence opened this issue Jan 10, 2022 · 1 comment
Labels
bug

Comments

@DarkSilence
Copy link

DarkSilence commented Jan 10, 2022 •
edited
Loading

Since self::flush accepts an int as a parameter but a bool is provided here:

sitemap/Sitemap.php

Line 184 in a7ba091

$this->flush(true);

It seems that it's a typo of some kind. Probably

$this->flush(0);

should be there.
@DarkSilence DarkSilence mentioned this issue Jan 10, 2022
Closed
@samdark samdark added the bug label Jan 10, 2022
@samdark
Copy link
Owner

samdark commented Jan 10, 2022

Yes, looks valid. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samdark @DarkSilence