Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions/upload-artifact to v4 #5325

Merged
merged 9 commits into from
Dec 24, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Dec 18, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Now test workflows use updated actions for upload and download artifacts. In version 4 artifacts are immutable

The contents of an Artifact are uploaded together into an immutable archive. They cannot be altered by subsequent jobs unless the Artifacts are deleted and recreated (where they will have a new ID). Both of these factors help reduce the possibility of accidentally corrupting Artifact files.

As we using multiple shards I had to add unique name for each artifact and then use v4 for action for download artifact with natch patter and merge multiple props:

    - name: Download blob reports from GitHub Actions Artifacts
      uses: actions/download-artifact@v4
      with:
        path: all-blob-reports
        pattern: all-blob-reports-*
        merge-multiple: true

Migration guide: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 5c3fd4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5325 December 18, 2024 12:08 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5325 December 18, 2024 12:21 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5325 December 18, 2024 13:55 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5325 December 18, 2024 14:22 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5325 December 18, 2024 14:34 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5325 December 18, 2024 14:53 Destroyed
@poulch poulch marked this pull request as ready for review December 18, 2024 15:07
@poulch poulch requested review from a team as code owners December 18, 2024 15:07
Cloud11PL
Cloud11PL previously approved these changes Dec 18, 2024
@github-actions github-actions bot temporarily deployed to pr-5325 December 18, 2024 19:03 Destroyed
andrzejewsky
andrzejewsky previously approved these changes Dec 19, 2024
@github-actions github-actions bot temporarily deployed to pr-5325 December 19, 2024 09:43 Destroyed
@andrzejewsky andrzejewsky merged commit 0da914a into main Dec 24, 2024
15 checks passed
@andrzejewsky andrzejewsky deleted the merx-1360-updte-upload-action-artifact branch December 24, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants