Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added switch focus using tab button #5320

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Added switch focus using tab button #5320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
00b51e1
Added switch focus using tab button
michalina-graczyk Dec 12, 2024
71db533
Remove keyboard from attributes page
michalina-graczyk Dec 12, 2024
114c7b6
Merge branch 'main' into Merx-saleor_128_improvment
michalina-graczyk Dec 16, 2024
024fdcf
Merge branch 'main' into Merx-saleor_128_improvment
michalina-graczyk Dec 17, 2024
6d49136
Add comment
michalina-graczyk Dec 17, 2024
16234ec
Added more precised comment
michalina-graczyk Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-gifts-hear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Added switch focus using tab button, that may delay saving before input is filled.
2 changes: 2 additions & 0 deletions playwright/tests/attributes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ for (const attr of ATTRIBUTES.attributesToBeUpdated) {
await attributesPage.metadataAddFieldButton.click();

await attributesPage.fillMetadataFields("new key", "new value");
//Clicking tab only to change focus from the input, allowing to save metadata
await attributesPage.page.keyboard.press("Tab");

await attributesPage.clickSaveButton();
await attributesPage.expectSuccessBanner();
Expand Down
Loading